Conversation
## Description With this PR, settings menu is using eto.forms, making it compatible with Mac. ## Breaking Changes There could be issues when saving settings, although non breaking change was detected during testing. ## Testing Done Couldn't try in Mac, but on windows works perfect. ## Checklist - [x] This PR is focused on a single feature or bug fix - [x] Version in Solution.props was updated, if necessary, and follows semantic versioning - [x] CHANGELOG.md has been updated - [x] PR title follows [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) format - [x] PR description follows [Pull Request Description Template](#pull-request-description-template)
…s when color doesn't match the requirements based on version type
## Description Improved version badge workflow to also update badges when color doesn't match the requirements based on version type. ## Breaking Changes None detected. ## Testing Done None. ## Checklist - [x] This PR is focused on a single feature or bug fix - [x] Version in Solution.props was updated, if necessary, and follows semantic versioning - [x] CHANGELOG.md has been updated - [x] PR title follows [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) format - [x] PR description follows [Pull Request Description Template](#pull-request-description-template)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project version to 0.2.0-dev and includes minor improvements to code quality and badge generation.
- Converted helper methods in AboutDialog.cs to static as they do not rely on instance state.
- Updated version and status badges in README.md and changelog entries to reflect the new version.
- Modified badge generation logic and badge color/status values in the GitHub action workflow.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SmartHopper.Menu/Dialogs/AboutDialog.cs | Made helper methods static. |
| README.md | Updated version and status badge URLs. |
| CHANGELOG.md | Documented updates regarding badge workflow and settings menu. |
| .github/actions/version-tools/action.yml | Adjusted badge generation logic and updated badge colors/status. |
Files not reviewed (1)
- Solution.props: Language not supported
Comments suppressed due to low confidence (2)
.github/actions/version-tools/action.yml:146
- Consider grouping the condition expressions with parentheses to ensure the intended evaluation order and improve clarity.
if [[ "$CURRENT_VERSION_BADGE" != *"$ENCODED_VERSION"* || "$CURRENT_VERSION_BADGE" != *"-$COLOR"* ]]; then
.github/actions/version-tools/action.yml:147
- Review the sed substitution regex to ensure it robustly matches the intended badge URL format across different environments, particularly if running on non-GNU sed systems.
sed -i "s|\[\!\[Version\](https://img\.shields\.io/badge/version[^)]*)|[|g" README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the project version to 0.2.0-dev and includes minor improvements to code quality and badge generation.
Breaking Changes
None detected.
Testing Done
RH8.17 on windows
Checklist