You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this PR we introduce a top-level attribute with mappings from CPU family/model numbers to the corresponding microarchitecture names. At the moment this is a prototype to showcase a possible enhancement of the detection algorithm on x86_64 processors.
https://en.wikichip.org/wiki/intel/cpuid shows that you can't distinguish between Skylake (Server), Cascade Lake, and Cooper Lake based on family/model info, so I'm not sure how that's going to work out, since there's a difference in supported instructions (like avx512ifma supported by Cooper Lake + Cascade Lake, but not Skylake, and avx512_vnni supported by Cascade Lake but not Cooper Lake & Skylake)...
The idea is to prefilter the architectures we check for compatibility. Not sure it's worth merging this change, but I wanted to write the draft idea somewhere since on icelake I got a 3x speed-up on detection.
alalazo
changed the title
Add a new top level attribute
Add CPU family/model information as a top level attribute
Feb 14, 2024
The reason will be displayed to describe this comment to others. Learn more.
@isuruf Out of curiosity, do you know of any CPU that needs to be disambiguated by vendor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a top-level attribute with mappings from CPU family/model numbers to the corresponding microarchitecture names. At the moment this is a prototype to showcase a possible enhancement of the detection algorithm on x86_64 processors.
If the approach seems ok, then we need to add the remaining data points from https://en.wikichip.org/wiki/intel/cpuid and https://en.wikichip.org/wiki/amd/cpuid