fix: abort database deletion when create_database exists#1394
Open
ju5t wants to merge 1 commit intoarchtechx:masterfrom
Open
fix: abort database deletion when create_database exists#1394ju5t wants to merge 1 commit intoarchtechx:masterfrom
create_database exists#1394ju5t wants to merge 1 commit intoarchtechx:masterfrom
Conversation
ju5t
changed the title
ju5t
changed the title
create_database exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the
DeleteDatabasestops whencreate_databaseis set to false for the tenant. This ensures that removing the tenant that had thecreate_databaseflag set to true can be done.Let me know what you think and if I should make any changes.