You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i tried and refactored some parts and added a new config though for absolute path seems that the CRA you initially created project with have some issue
Hey @mjn81
Thank you very much for your contribution.
I believe you used prettier to format the code base and I appreciate your help
Can you explain the updates that you made to the configs and the way they are going to benefit this project?
hi! first i updated prettier format file (As you said) second i updated ts-config file third i added react rewired plus refactored project dependencies (some dev deps were inside deps) changed yarn start to yarn dev cuz its more common! also tried to add relative path but somehow it didnt work correctly so i added comment that this parts should be changed later. you added some ts-ignore part which either some of them were wrong so i removed them or moved them to the write place. also changed component directory name to components. i believe this project needs a much more in depth refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i tried and refactored some parts and added a new config though for absolute path seems that the CRA you initially created project with have some issue