Skip to content

refactored project a bit, though it needs more !#20

Open
mjn81 wants to merge 1 commit intoariannargesi:masterfrom
mjn81:master
Open

refactored project a bit, though it needs more !#20
mjn81 wants to merge 1 commit intoariannargesi:masterfrom
mjn81:master

Conversation

@mjn81
Copy link

@mjn81 mjn81 commented Sep 9, 2022

i tried and refactored some parts and added a new config though for absolute path seems that the CRA you initially created project with have some issue

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for wondrous-dolphin-fccbd2 ready!

Name Link
🔨 Latest commit 09e1dd6
🔍 Latest deploy log https://app.netlify.com/sites/wondrous-dolphin-fccbd2/deploys/631aba7cc54e0d000954d685
😎 Deploy Preview https://deploy-preview-20--wondrous-dolphin-fccbd2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ariannargesi
Copy link
Owner

Hey @mjn81
Thank you very much for your contribution.
I believe you used prettier to format the code base and I appreciate your help
Can you explain the updates that you made to the configs and the way they are going to benefit this project?

@mjn81
Copy link
Author

mjn81 commented Sep 9, 2022

hi! first i updated prettier format file (As you said) second i updated ts-config file third i added react rewired plus refactored project dependencies (some dev deps were inside deps) changed yarn start to yarn dev cuz its more common! also tried to add relative path but somehow it didnt work correctly so i added comment that this parts should be changed later. you added some ts-ignore part which either some of them were wrong so i removed them or moved them to the write place. also changed component directory name to components. i believe this project needs a much more in depth refactoring

@github-staff github-staff deleted a comment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants