feat(dashboard): RP-7206 spell checker with typo-js#4
Open
itainaor-arpeely wants to merge 5 commits intomultiline-0.49.0from
Open
feat(dashboard): RP-7206 spell checker with typo-js#4itainaor-arpeely wants to merge 5 commits intomultiline-0.49.0from
itainaor-arpeely wants to merge 5 commits intomultiline-0.49.0from
Conversation
OfirTadmor
reviewed
Dec 12, 2024
esm/vs/language/json/json.worker.js
Outdated
Comment on lines
+3623
to
+3641
| var cumulativeLength = specialCharsBeforeLength; | ||
|
|
||
| var spellResults = words.reduce((acc, word, index) => { | ||
| if (isNaN(word) && !dictionary.check(word)) { | ||
| var wordStartPosition = scanner.getTokenOffset() + cumulativeLength + 1; | ||
| var wordEndPosition = wordStartPosition + word.length | ||
|
|
||
| acc.push({ | ||
| word, | ||
| suggestions: [], | ||
| start: wordStartPosition, | ||
| end: wordEndPosition | ||
| }); | ||
| } | ||
|
|
||
| cumulativeLength += word.length + (delimiters.length > index ? delimiters[index].length : 0); | ||
|
|
||
| return acc; | ||
| }, []); |
There was a problem hiding this comment.
I think it's a bad practice to mutate from inside a reduce (we can pass the cumulativeLength as the part of the acc variable instead )
OfirTadmor
approved these changes
Dec 12, 2024
molotbar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file:../../../../monaco-editor, and runpnpm install.src/assets/static/typo-js/en_USthe attached filesaff&dic.zip