feat(inquiry): inquiry modal prompt updates#16786
Merged
rquartararo merged 15 commits intomainfrom Feb 18, 2026
Merged
Conversation
rquartararo
commented
Feb 11, 2026
| <AppContainer px={[2, 4]} py={4}> | ||
| <GridColumns> | ||
| <Column span={4} start={5}> | ||
| <Column span={[12, 6, 4]} start={[1, 4, 5]}> |
Member
Author
There was a problem hiding this comment.
The toast width is too small on medium screens (ipad) so this fixes it.
#6802 Bundle Size — 8.64MiB (+0.02%).257a12a(current) vs 41e8c21 main#6799(baseline) Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
|
| Current #6802 |
Baseline #6799 |
|
|---|---|---|
 Initial JS |
2.84MiB(~+0.01%) |
2.83MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
27.07% |
16.35% |
| Chunks |
110 |
110 |
| Assets |
113 |
113 |
| Modules |
5511 |
5511 |
| Duplicate Modules |
616(+0.16%) |
615 |
| Duplicate Code |
4.93%(+0.2%) |
4.92% |
| Packages |
250 |
250 |
| Duplicate Packages |
30 |
30 |
Bundle size by type 1 change 1 regression
| Current #6802 |
Baseline #6799 |
|
|---|---|---|
| JS |
8.49MiB (+0.02%) |
8.49MiB |
| Other |
152.73KiB |
152.73KiB |
Bundle analysis report Branch review-app-inquiry-modal Project dashboard
Generated by RelativeCI Documentation Report issue
rquartararo
force-pushed
the
review-app-inquiry-modal
branch
from
2150bb8 to
e16edbe
Compare
oxaudo
previously approved these changes
Feb 12, 2026
Member
oxaudo
left a comment
oxaudo
left a comment
There was a problem hiding this comment.
This looks good to me except for couple of nitpicks. We can def iterate.
Couple of questions to follow up:
- do we need to add the check for 'recently prompted' to profile details as well? As is we'll keep prompting for collector details after every inquiry?
- the interactions in the 'add artists' modal is not the most intuitive but I suspect that is out of scope now, right?
- And the last small visual thing. The 'I haven't started a collection' underlined as link in design. Also kinda funny when one clicks on it. It's a button?
Member
Author
|
@oxaudo asked your questions to vivi in the slack thread. As for the 'I haven't started a collection' button, I will convert it to a text link 👍 |
rquartararo
force-pushed
the
review-app-inquiry-modal
branch
from
53190a3 to
d177f0f
Compare
Member
|
@rquartararo would this change need corresponding Integrity update? |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feature
This PR solves EMI-3075
Review App
@artsy/emerald-devs
Description
Complete profile prompt
Screen.Recording.2026-02-11.at.2.25.25.PM.mov
Update profile prompt
Screen.Recording.2026-02-11.at.2.27.31.PM.mov