fix(EMI-3077): express checkout error messaging#16796
Merged
erikdstock merged 3 commits intomainfrom Feb 16, 2026
Merged
Conversation
0a02458 to
728f58a
Compare
#6737 Bundle Size — 8.61MiB (~+0.01%).cfbd7ec(current) vs c437dc0 main#6721(baseline) Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch erik.emi3077-express-checkout-er... Project dashboard Generated by RelativeCI Documentation Report issue |
728f58a to
c703526
Compare
Move express checkout errors to use the checkout context's step error system instead of local component state. This ensures errors are cleared automatically when the user completes the fulfillment details step. - Replace local error state with CheckoutStepName.FULFILLMENT_DETAILS step error - Use setStepErrorMessage/messages from checkout context - Errors now persist through checkout flow and clear when step completes - Remove dependency on checkoutMode for error banner visibility - Update tests to verify setStepErrorMessage calls Benefits: - Consistent error handling across all checkout steps - Errors automatically clear when user progresses through checkout - No need to manually manage error state lifecycle Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…complete When a user encounters an error during express checkout and then manually completes the fulfillment details step, the express checkout error message is now automatically cleared. This prevents stale error messages from persisting in the UI after the user has successfully moved past that step. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
c703526 to
ce5e51a
Compare
erikdstock
commented
Feb 16, 2026
Comment on lines
+11
to
+12
| // Sections that can display error messages | ||
| export type CheckoutSection = CheckoutStepName | "EXPRESS_CHECKOUT" |
Contributor
Author
There was a problem hiding this comment.
Weirdest part of this PR - since we don't treat express checkout as a step, i made the 'message' concept now apply to a union type. This makes it easier to set and unset error messages from anywhere.
erikdstock
commented
Feb 16, 2026
| setExpressCheckoutState("active") | ||
|
|
||
| setExpressCheckoutType(expressPaymentType) | ||
| unsetStepError() // Clear any previous errors |
Contributor
Author
There was a problem hiding this comment.
claude slop comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #16795
The type of this PR is: fix
This PR solves EMI-3077
Description
This PR makes the express checkout error message and clearing part work the same as other error banners. Express check out error errors will disappear when the user continues through the normal checkout flow.