Fix crash when CloudKit returns records without fields#11
Open
asabirov wants to merge 1 commit intosync/upstream-mainfrom
Open
Fix crash when CloudKit returns records without fields#11asabirov wants to merge 1 commit intosync/upstream-mainfrom
asabirov wants to merge 1 commit intosync/upstream-mainfrom
Conversation
Add custom CKRecord decoder that handles missing/empty fields gracefully instead of crashing on decode. Add tests for record decoding edge cases. (reimplements PR #3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CloudKit's
records/lookupcan return records without afieldskey (not-found/deleted records), causing akeyNotFounddecoding crash.Fix
Decodableinit forCKRecordthat defaultsfieldsto[:]when missinglookupRecordssogetcorrectly falls through touniqueIdentifiersearchBearNoteedge cases