feat: Caching Feature (implements #235)#596
Open
flosell wants to merge 22 commits intoasdf-vm:masterfrom
Open
Conversation
…e asdf-version was changed asdf-vm#235
Before, this was implicitly done by pluginsAdd but we now need it before installing plugins to get the current asdf version for the cache-key
…nal detail that the user doesn't need to see asdf-vm#235
…ngs get added if we find a stale cache asdf-vm#235
…o support the toolVersions input during caching asdf-vm#235
flosell
changed the title
flosell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#235 suggests good workaround for implementing caching for plugins and install. However, adding these to every pipeline makes the pipeline more noisy and harder to read. It's also less intuitive than a first-party implementation.
So here's a PR that'd implements jaymecds workaround directly in the action, with three differences:
tool_versionsinput to the actionasdf installeven when a cache was restored, so that stale or partial caches can be rectifiedenable_cacheinputI tested this with a few of my pipelines and found it quite helpful, at least when using plugins that install from source (e.g. ruby). Open to feedback though.
What do you think?