Skip to content

Automatically fetch latest ruby-build version with 24h cache#484

Open
exterm wants to merge 3 commits into
asdf-vm:masterfrom
ClockworkEnergy:always-use-latest-ruby-build
Open

Automatically fetch latest ruby-build version with 24h cache#484
exterm wants to merge 3 commits into
asdf-vm:masterfrom
ClockworkEnergy:always-use-latest-ruby-build

Conversation

@exterm
Copy link
Copy Markdown
Contributor

@exterm exterm commented Jan 14, 2026

Fetches the newest ruby-build version whenever ruby-build is used, with a 24 hour cache.

I wasn't sure about the cache, but it seems wasteful to fetch the newest version every time.

Fixes #464

@exterm exterm force-pushed the always-use-latest-ruby-build branch from bca5f07 to c27f94c Compare January 14, 2026 19:35
@exterm
Copy link
Copy Markdown
Contributor Author

exterm commented Jan 14, 2026

I was so unsure about the cache that I added a commit to remove it. We can merge this with or without cache. Maintainer's choice @Stratus3D

@runephilosof-abtion
Copy link
Copy Markdown

asdf-nodejs automatically fetches latest, so asdf-ruby should probably be structured similarly.

asdf-nodejs has a mention of a cache https://github.com/asdf-vm/asdf-nodejs/blob/master/lib/commands/command-nodebuild
But I don't think it is the same kind of cache that you had, however I only skimmed the code.

@exterm exterm force-pushed the always-use-latest-ruby-build branch from fb77da0 to 171fa54 Compare May 4, 2026 14:05
@exterm
Copy link
Copy Markdown
Contributor Author

exterm commented May 4, 2026

I was curious and dug into the asdf-nodejs code a bit. They are smarter on the fetches, don't re-fetch everything every time. I added a commit that should speed things up a bit. However as I'm not sure whether @Stratus3D is interested in merging something like this, I have not done extensive testing of this new commit yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use latest version of ruby-build by default

2 participants