fix: apply join_relationship filter/sort/limit in many_to_many lateral joins #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a many_to_many relationship uses a join_relationship with sort/limit/filter, those constraints weren't being applied in the lateral join query. Two issues: 1. The sort/limit/filter from the join_relationship weren't being added to the through_query at all 2. When the through_query is wrapped in a subquery, the parent correlation needs to be inside the subquery so the limit applies per-parent
Contributor
|
I've fixed the other failing tests (there are two flaky ones that might fail still) which may help with the testing story, but so far this LGTM |
Contributor
|
`thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a many_to_many relationship uses a join_relationship with sort/limit/filter, those constraints weren't being applied in the lateral join query.
Two issues:
This is related to ash-project/ash#2486 (hence why some of the code is the same) but for Postgres, which uses lateral joins.
(Claude was used in investigating and fixing this bug)
Contributor checklist
Leave anything that you believe does not apply unchecked.