Use transient instead of option as cache#13
Open
soderlind wants to merge 1 commit intoaskupasoftware:masterfrom
Open
Use transient instead of option as cache#13soderlind wants to merge 1 commit intoaskupasoftware:masterfrom
soderlind wants to merge 1 commit intoaskupasoftware:masterfrom
Conversation
…ped up by caching plugins, where normal Options are not. Add `$deps` to `wp_dynamic_css_enqueue`, $deps is an array of registered stylesheet handles this stylesheet depends on. Reformat code according to WordPress Coding Standards
Contributor
|
Hi there, thank you for the contribution, great PR! The Using transients is also a nice idea, however it defeats the purpose of our internal cache. We want to give the developer the option to clear the cache manually when a user changes a settings that affects the stylesheet. Using transient may cause the data to expire too often, even if the stylesheet hasn't changed. This will trigger the compiler every time and will cause a performance impact. Regarding the code formatting - i'm following a different format, and I would need to change the entire framework's code base to match that, so i'll wait on it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transients are inherently sped up by caching plugins, where normal Options are not.
Also:
$depstowp_dynamic_css_enqueue,$depsis an array of registered stylesheet handles this stylesheet depends on.