Skip to content

chore: fix mac ci#129

Merged
jbedard merged 1 commit intomainfrom
gha-macos-errors
Mar 9, 2026
Merged

chore: fix mac ci#129
jbedard merged 1 commit intomainfrom
gha-macos-errors

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented Mar 7, 2026

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Mar 7, 2026

Bazel 7 (Test)

All tests were cache hits

3 tests (100.0%) were fully cached saving 133ms.


Bazel 8 (Test)

All tests were cache hits

2 tests (100.0%) were fully cached saving 61ms.


Bazel 9 (Test)

All tests were cache hits

2 tests (100.0%) were fully cached saving 81ms.


Bazel 7 (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 8 (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.


Bazel 9 (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Workspace

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Bazel 7 (Test)

e2e/smoke_rjs3

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 8 (Test)

e2e/smoke_rjs3

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.


Bazel 9 (Test)

e2e/smoke_rjs3

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Buildifier

@jbedard jbedard marked this pull request as ready for review March 7, 2026 01:23
@jbedard jbedard requested a review from alexeagle March 7, 2026 01:23
@jbedard jbedard enabled auto-merge (squash) March 7, 2026 01:23
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5de6f02619

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yaml
bazel \
--bazelrc=${GITHUB_WORKSPACE//\\/\/}/tools/preset.bazelrc \
--bazelrc=${GITHUB_WORKSPACE//\\/\/}/.github/workflows/ci.bazelrc \
test \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore CI config for bazel smoke tests

Removing --config=ci from this Bazel invocation disables all *:ci settings defined in tools/preset.bazelrc (for example common:ci --lockfile_mode="error" and test:ci --flaky_test_attempts=2), so this workflow no longer enforces CI-only safeguards that it previously relied on. In practice, macOS/Windows smoke tests can now pass with an out-of-date lockfile and will be more flaky because retries are no longer enabled.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--config=ci is what is broken with the latest bazelrc-presets

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should comment this for now since we'll want it back when the presets are fixed. Can you open an issue on https://github.com/bazel-contrib/bazelrc-preset.bzl?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbedard jbedard force-pushed the gha-macos-errors branch from 5de6f02 to 31602a1 Compare March 7, 2026 02:37
Comment thread .github/workflows/ci.yaml
bazel \
--bazelrc=${GITHUB_WORKSPACE//\\/\/}/tools/preset.bazelrc \
--bazelrc=${GITHUB_WORKSPACE//\\/\/}/.github/workflows/ci.bazelrc \
test \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should comment this for now since we'll want it back when the presets are fixed. Can you open an issue on https://github.com/bazel-contrib/bazelrc-preset.bzl?

@jbedard jbedard merged commit bb42832 into main Mar 9, 2026
11 checks passed
@jbedard jbedard deleted the gha-macos-errors branch March 9, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants