Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5de6f02619
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bazel \ | ||
| --bazelrc=${GITHUB_WORKSPACE//\\/\/}/tools/preset.bazelrc \ | ||
| --bazelrc=${GITHUB_WORKSPACE//\\/\/}/.github/workflows/ci.bazelrc \ | ||
| test \ |
There was a problem hiding this comment.
Restore CI config for bazel smoke tests
Removing --config=ci from this Bazel invocation disables all *:ci settings defined in tools/preset.bazelrc (for example common:ci --lockfile_mode="error" and test:ci --flaky_test_attempts=2), so this workflow no longer enforces CI-only safeguards that it previously relied on. In practice, macOS/Windows smoke tests can now pass with an out-of-date lockfile and will be more flaky because retries are no longer enabled.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
--config=ci is what is broken with the latest bazelrc-presets
There was a problem hiding this comment.
I think we should comment this for now since we'll want it back when the presets are fixed. Can you open an issue on https://github.com/bazel-contrib/bazelrc-preset.bzl?
There was a problem hiding this comment.
5de6f02 to
31602a1
Compare
| bazel \ | ||
| --bazelrc=${GITHUB_WORKSPACE//\\/\/}/tools/preset.bazelrc \ | ||
| --bazelrc=${GITHUB_WORKSPACE//\\/\/}/.github/workflows/ci.bazelrc \ | ||
| test \ |
There was a problem hiding this comment.
I think we should comment this for now since we'll want it back when the presets are fixed. Can you open an issue on https://github.com/bazel-contrib/bazelrc-preset.bzl?


Changes are visible to end-users: no
Test plan