Conversation
| : m_pImpl(hub_connection_impl::create(url, trace_level, log_writer, http_client, websocket_factory)) | ||
| {} | ||
|
|
||
| hub_connection::hub_connection(hub_connection&& rhs) noexcept |
There was a problem hiding this comment.
Weren't we going to turn hub_connection_impl into hub_connection? Otherwise, we're essentially returning a share_ptr<shared_ptr<real_hub_connection> >. While not necessarily wrong, I don't see the point.
There was a problem hiding this comment.
I gave a little explanation in the initial PR comment
There was a problem hiding this comment.
We talked about replacing the hub_connection_impl and making hub_connection contain all the logic. However, that would require including a lot of internal types in the public header and all sorts of ugliness.
There has to be some way to get rid of the redundant share_ptr without exposing internal types, no?
|
This change would be great @BrennanConroy. We've recently got this client working in Unreal, but the current API makes it difficult to store a This change looks like the right kind of solution. |
|
Looks like there's a move constructor available for |
454f88f to
a0cf783
Compare
We talked about replacing the hub_connection_impl and making hub_connection contain all the logic. However, that would require including a lot of internal types in the public header and all sorts of ugliness.