Skip to content

Fix PHPStan return type annotation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylfabre merged 3 commits into from
Feb 14, 2026
Merged

Fix PHPStan return type annotation #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4ce3ff
Fix PHPStan return type annotation
sylfabre Feb 13, 2026
25e2aa2
Require validator-bundle ^2.39.2 for static data providers
sylfabre Feb 14, 2026
5d05cbb
Make data providers static (Rector)
sylfabre Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"assoconnect/php-percent": "^1.1",
"doctrine/dbal": "^2.10|^3.0",
"symfony/serializer": "^7.0",
"assoconnect/validator-bundle": "^2.32"
"assoconnect/validator-bundle": "^2.39.2"
},
"config": {
"allow-plugins": {
Expand Down
2 changes: 1 addition & 1 deletion tests/Doctrine/DBAL/Types/PercentTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function testConvertStringToPHPValue(): void
}

/**
* @return mixed[][]
* @return list<array<mixed>>
*/
public static function invalidPHPValuesProvider(): iterable
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Validator/Constraints/PercentValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function createValidator(): ConstraintValidator
return new PercentValidator();
}

public function providerValidValues(): iterable
public static function providerValidValues(): iterable
{
yield [null];
yield [10.0];
Expand All @@ -40,7 +40,7 @@ public function providerValidValues(): iterable
yield [new \AssoConnect\PHPPercent\Percent(20)];
}

public function providerInvalidValues(): iterable
public static function providerInvalidValues(): iterable
{
yield [
'a',
Expand Down
2 changes: 1 addition & 1 deletion tests/Validator/ConstraintsSetProvider/Field/PercentProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ protected function getFactory(): FieldConstraintsSetProviderInterface
return new PercentProvider();
}

public function getConstraintsForTypeProvider(): iterable
public static function getConstraintsForTypeProvider(): iterable
{
yield [
[
Expand Down
Loading