Skip to content

Apply Rector fixes: make data providers static #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylfabre merged 1 commit into from
Feb 14, 2026
Merged

Apply Rector fixes: make data providers static #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Resolver/BounceTypeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function testResolveBounceMessagesCorrectly(string $expected, string $bou
self::assertEquals($expected, $resolver->resolve($bounceReason));
}

public function provideBounceReasons(): iterable
public static function provideBounceReasons(): iterable
{
yield 'DMarc failure' => [BounceTypeResolver::BOUNCE_REASON_DMARC_FAILURE, 'Email rejected per DMARC policy'];
yield 'Blacklisted' => [BounceTypeResolver::BOUNCE_REASON_BLACKLISTED, 'LPN007_510'];
Expand Down
2 changes: 1 addition & 1 deletion tests/Resolver/ProviderResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function testProviderResolverReturnsTheRightProvider(string $address, ?st
self::assertSame($provider, $resolver->resolve($address));
}

public function provideAddressesAndProviders(): iterable
public static function provideAddressesAndProviders(): iterable
{
// Without DNS check
yield ['john@hotmail.com', 'microsoft'];
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/BounceIsCausedByInactiveUserSpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function testSpecificationWorks(string $message, bool $isSpam): void
}

/** @return array{string, bool}[] */
public function provideMessages(): iterable
public static function provideMessages(): iterable
{
yield ['Email rejected per SPAM policy', false];
yield [
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/BounceIsCausedByOverQuotaSpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function testSpecificationWorks(string $message, bool $isSpam): void
}

/** @return array{string, bool}[] */
public function provideMessages(): iterable
public static function provideMessages(): iterable
{
yield ['Email rejected per SPAM policy', false];
yield [
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/BounceIsCausedByUnknownUserSpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function testSpecificationWorks(string $message, bool $isSpam): void
}

/** @return array{string, bool}[] */
public function provideMessages(): iterable
public static function provideMessages(): iterable
{
yield ['Email rejected per SPAM policy', false];
yield ['Sender address rejected: Sender user unknown. Adresse expediteur inconnue', true];
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/BounceIsSpamRelatedSpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function testSpecificationWorks(string $message, bool $isSpam): void
}

/** @return array{string, bool}[] */
public function provideMessages(): iterable
public static function provideMessages(): iterable
{
yield ['Email rejected per SPAM policy', true];
yield ['Sender address rejected: Sender user unknown. Adresse expediteur inconnue', false];
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/BounceReasonIsUnknownSpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function testSpecificationWorks(string $message, bool $isSpam): void
}

/** @return array{string, bool}[] */
public function provideMessages(): iterable
public static function provideMessages(): iterable
{
yield ['hard bounce', true];
yield ['Sender address rejected: Sender user unknown. Adresse expediteur inconnue', false];
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/EmailAddressIsFromACountrySpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function testSpecificationWorks(string $emailAddress, string $country, bo
self::assertSame($isSatisfiedBy, $spec->isSatisfiedBy($emailAddress, $country));
}

public function provideEmailAddresses(): iterable
public static function provideEmailAddresses(): iterable
{
// Invalid
yield ['hello', 'FR', false];
Expand Down
2 changes: 1 addition & 1 deletion tests/Specification/EmailAddressIsFromAProviderSpecificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function testSpecificationWorks(string $emailAddress, string $providerNam
self::assertSame($isSatisfiedBy, $spec->isSatisfiedBy($emailAddress, $providerName, true));
}

public function provideEmailAddresses(): iterable
public static function provideEmailAddresses(): iterable
{
yield ['invalid email', '', false];
yield ['unknow provider', 'provider that does not exist', false];
Expand Down
2 changes: 1 addition & 1 deletion tests/Translatable/BounceReasonTranslatableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testBounceReasonTranslatable(string $reason, string $expectedTra
/**
* @return iterable<mixed>
*/
public function providerTrans(): iterable
public static function providerTrans(): iterable
{
yield 'code' => [
'2.2.1 test code',
Expand Down
2 changes: 1 addition & 1 deletion tests/Validation/SmtpValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function testClientWorks(string $email, string $expectedDtoClass): void
}

/** @return array{0: string, 1: class-string<ValidationStatusDtoInterface>}[] */
public function provideEmailAddresses(): iterable
public static function provideEmailAddresses(): iterable
{
yield ['this_user_does_not_exist', InvalidAddressDto::class];
yield ['this_user_does_not_exist@this_domain_does_not_exist', InvalidAddressDto::class];
Expand Down
Loading