Open
Conversation
doterik
force-pushed
the
shared
branch
2 times, most recently
from
dfc8b4b to
81755ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I read your article “Fast Search and Replace” on CodeProject and found it very interesting. Although memory-mapping wasn’t entirely unfamiliar to me, I haven’t used it on a larger scale before.
I believe I found a bug; specifically, if the replaced text is shorter, it isn’t handled correctly. Another thing that bothered me significantly was that all files were updated, meaning they received a new date even if no changes had occurred. I can’t emphasize enough how much I disliked this behavior.
Now, I’ve extracted common parts from the Forms and Console applications into a separate library, updated the Sdk, and .NET version. Otherwise, the code should remain fairly intact except for formatting, where we diverge quite a bit (I have a wide screen).
I’m submitting this as a pull request (PR), not with the intention of you accepting it, but more as a basis for alternative approaches. If you have time, feel free to review it and provide suggestions. I’ll leave this PR open for about a week before removing it.
About
Alphaleonis.Win32.Filesystemalphaleonis/AlphaFS#529 (comment)I refrain from commenting on how I feel about suggesting old outdated packages.
Likewise, regarding
Newtonsoft.Jsoninstead ofSystem.Text, perhaps more of a taste.Thank you for sharing this library, I would be pleased if you could compile and run my repo at least once.
Regards,