fix: do not omit patternProperties when properties is undefined

[theAnuragMishra]

Description

Changes proposed in this pull request:

• the current implementation of SchemaProperties component skips and returns null if properties is undefined which shows no patternProperties even if they are present
• this pr converts properties and patternProperties to empty objects in case they are undefined. If there's nothing to show, Object.entries maps nothing and nothing is rendered which is desired.
• this fixes the bug where patternProperties is omitted when properties is undefined.

Related issue(s)
closes #1197

[theAnuragMishra]

@derberg can you pleaseee ehave a look? it's been so looong (the original pr was #1199 )

[AceTheCreator]

Left you a review :)

[theAnuragMishra]

@AceTheCreator so you ignore the pr for a month, come and suggest a change to remove empty fragment possibility and then disappear again? If you don't like useful prs and are only interested in reviewing prs that shift a div from one place to the other, please feel free to close the pr. Don't keep someone hanging for so long for a pr that's not even 10 lines of change.

[AceTheCreator]

@AceTheCreator so you ignore the pr for a month, come and suggest a change to remove empty fragment possibility and then disappear again? If you don't like useful prs and are only interested in reviewing prs that shift a div from one place to the other, please feel free to close the pr. Don't keep someone hanging for so long for a pr that's not even 10 lines of change.

Are you aware that your PR test failed? Please refrain from accusations like this moving forward. Thank you

[AceTheCreator]

Also, there wasn’t a clear signal that your PR was ready for another review since the conversation hadn’t been resolved.

Please don’t place the blame on me, or any maintainer, for that. It’s important we follow the process so everyone stays aligned. At the end of the day, it’s open source; let’s keep it constructive and not take things personally.

[theAnuragMishra]

Ok sorry. The pr was up for tooo long so i crashed out. The failing check was related to formatting which I have fixed. I think everything should be as expected now. Please have a look.

[theAnuragMishra]

@AceTheCreator

[AceTheCreator]

One last review @theAnuragMishra. The potential issue I see with this current implementation is that if you only want to render when there's actual data, you might want to conditionally render each map individually.

[theAnuragMishra]

conditionally render each map individually

so like, {properties.lenght > 0 && properties.map(...?
or are u suggesting two separate components for properties and patternProperties

@AceTheCreator

[theAnuragMishra]

@AceTheCreator can u please collaborate on this for once and merge / close as needed?

[AceTheCreator]

so like, {properties.lenght > 0 && properties.map(...?

Yes 👍🏾

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[theAnuragMishra]

I don't think that's necessary. We return if both arrays are empty which means an empty fragment will never be rendered. properties.map or patternproperties.map do nothing if the array is empty.

[AceTheCreator]

I don't think that's necessary. We return if both arrays are empty which means an empty fragment will never be rendered. properties.map or patternproperties.map do nothing if the array is empty.

Yea, that’s true if both arrays are empty (&&). But if only one of them is provided, the other would still render an empty fragment, no?

[theAnuragMishra]

no, because .map on an empty array renders nothing, not even an empty fragment.

[AceTheCreator]

no, because .map on an empty array renders nothing, not even an empty fragment.

Agreed 👍🏾

[AceTheCreator]

LGTM!

[AceTheCreator]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀