Fix add_comment_to_object using params instead of data#1627
Open
star7js wants to merge 1 commit intoatlassian-api:masterfrom
Open
Fix add_comment_to_object using params instead of data#1627star7js wants to merge 1 commit intoatlassian-api:masterfrom
star7js wants to merge 1 commit intoatlassian-api:masterfrom
Conversation
…T body (closes atlassian-api#1596) The Insight/Assets comment create endpoint expects JSON in the request body, not query string parameters. Using params= causes a 500 error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_comment_to_objectin bothinsight.pyandassets.pywas sending the comment payload as query string parameters (params=) instead of a JSON request body (data=), causing a 500 error from the server.Closes #1596