Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

🎨 lazy load git-utils since this is the only usage#32

Open
basarat wants to merge 1 commit intoatom:masterfrom
basarat:patch-2
Open

🎨 lazy load git-utils since this is the only usage#32
basarat wants to merge 1 commit intoatom:masterfrom
basarat:patch-2

Conversation

@basarat
Copy link
Copy Markdown
Contributor

@basarat basarat commented Jan 15, 2016

It is very unlikely that will give any performance gain. The main motivation I have is to use this package as a fork where I simply remove git-utils as a package dependency (as that needed a working node-gyp toolchain) and use this package as is without triggering the git-utils code path.

I would completely understand if you want to disregard this PR 🌹 👍

@lee-dohm
Copy link
Copy Markdown
Contributor

@benogle Have any issues with this?

@benogle
Copy link
Copy Markdown
Contributor

benogle commented Jan 15, 2016

I'd prefer we use the pattern we use elsewhere. Though I'm not sure if is actually any faster. Anyone know?

GitUtils = null

constructor: ->
  GitUtils ?= require 'git-utils'
  GitUtils.func....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants