Fix test_supervisor:try_again_restart/0 test
#2022
Draft
+107
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w49/fix-test-supervisor
branch
from
14b5116 to
87770c6
Compare
pguyot
force-pushed
the
w49/fix-test-supervisor
branch
2 times, most recently
from
90fb2da to
2c7ac33
Compare
Test was flappy but in fact it was succeeding because of a race condition. If intensity if 5, supervisor should not have 5 restarts in its children or will shut down. Make test more robust using monitors, references, assertion of exit reasons and removing a potential race condition with a registered name. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w49/fix-test-supervisor
branch
from
2c7ac33 to
480cb1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was flappy but in fact it was succeeding because of a race condition. If intensity if 5, supervisor should not have 5 restarts in its children or will shut down. Make test more robust using monitors and add a new test to assert the number of restarts that cause a shutdown.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later