Fix flappiness case of test_gen_server:test_timeout_info/0
#2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using computed sleep times which CI doesn't like, implement a callback mechanism to test that indeed timeout messages are sent. Also fix `test_start_name/0` so it doesn't leave an unprocessed `EXIT` message if trap_exit flag was true. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
UncleGrumpy
approved these changes
Dec 7, 2025
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
Thanks again for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using computed sleep times which CI doesn't like, implement a callback mechanism to test that indeed timeout messages are sent.
Also fix
test_start_name/0so it doesn't leave an unprocessedEXITmessage if trap_exit flag was true.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later