Add missing tests for uf2create and pico_flash tasks#57
Open
UncleGrumpy wants to merge 5 commits intoatomvm:masterfrom
Open
Add missing tests for uf2create and pico_flash tasks#57UncleGrumpy wants to merge 5 commits intoatomvm:masterfrom
UncleGrumpy wants to merge 5 commits intoatomvm:masterfrom
Conversation
Merged
Fixes incorrect (`rp2035`) chip name, which could lead to confusion and errors when the correct name `rp2350` was uses for the uf2create task. Signed-off-by: Winford <winford@object.stream>
Make the logging of the uf2create provider more verbose when running under tests so output can be parsed and verified with expected results. Signed-off-by: Winford <winford@object.stream>
Adds a suite of tests for the uf2create provider. Signed-off-by: Winford <winford@object.stream>
Add some more verbose logging (when in test mode) to give test the ability to parse parameters sent to picotool. Reduces times waiting for mount points, since we are not waiting for real hardware to settle. Allows the use of a mock esptool for testing under CI or when no RP2 hardware is present. Signed-off-by: Winford <winford@object.stream>
Adds a suite of test for the pico_flash provider using a mock esptool.sh to simulte devices needing reset and creating a mountpoint. Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
missing_tests
branch
from
d659499 to
fad73eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for uf2create and pico_flash providers. Tests use a mock picotool.sh to simulate using picotool to reset a device into usb mode and create a mountpoint.
Fixes a typo/bug that was used in the uf2create provider and documentation that would cause a
family_idofrp2350to raise an error.Closes #53