-
Notifications
You must be signed in to change notification settings - Fork 14
Code warning: show module and function name #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Peter M <petermm@gmail.com>
Signed-off-by: Peter M <petermm@gmail.com>
|
Yes, it does even though (at least in my case) it's not really helping too much, because it's caused by some macros (that get expanded into my app) defined in a library and not by my app. Of course it reports it in my app and I'm also not surprised it's in The change surely doesn't harm, but not sure how much it really helps :-( Probably for normal functions (i.e. not macros) it would help to figure out which function introduces the issue. |
Signed-off-by: Peter M <petermm@gmail.com>
|
Yeah, I feared that - I've added an experimental macro tracer (or rather claude did) - can you give it a whirl? otherwise I feel like this may not warrant that much effort, but an minimal repro could be nice to have for reference.. |
|
Not sure this is really helpful: |
Signed-off-by: Peter M <petermm@gmail.com>
|
I don't think it's really worth to spend too much time on it. Probably it's better to look at documenting on how to chase the issue.
The |
|
Agreed, I did make one final attempt - but pending a minimal repro, I can't do much more.. (you can also just add me to some private github repo, doesn't have to be pretty, just if I can pull it and add as dep and get the warnings..) |
|
I'll make the repo public anyway... now just a couple of days earlier. Let me try to do it this evening |
|
Find the repo here: It currently uses the fledex The other issue can easily be triggered by changing the code in def start do
# we need to disable the color selection, because it uses
# functions that are not available in atomvm
use Fledex # , colors: nil
# lets' include the CSS colors so we can skip the module name
# import Fledex.Color.Names.CSS
...
|
|
Actually while preparing the code for uploading, I felt that the warning is not soo bad :-) |
eg:
Fixes #67