Fix cmake binary output dir + enable build CI on PRs#7
Merged
Conversation
Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CMake configuration to resolve OpenMP not found warnings
Fix binary not found after cmake build: handle ggml's build/bin/ output directory
Mar 1, 2026
…spatch Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot
AI
changed the title
Fix binary not found after cmake build: handle ggml's build/bin/ output directory
Fix cmake binary output dir + enable build CI on PRs
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
acestep.cppis built via cmake, ggml'sCMakeLists.txtsilently redirects all executables to${CMAKE_BINARY_DIR}/binwhen used as a subdirectory — soace-qwen3anddit-vaeland inbuild/bin/instead ofbuild/. Every binary search in this repo only looked inbuild/, so builds appeared to produce nothing.Additionally, the
build-testCI job was gated onworkflow_dispatchonly, meaning the fix was never automatically verified on PRs.Changes
install.py+nodes.py— fix binary output directory-DCMAKE_RUNTIME_OUTPUT_DIRECTORY={build_dir}to cmake so new builds always emit binaries intobuild/directly_binary_exists(install.py) and_binary_in_build(nodes.py) helpers that check bothbuild/andbuild/bin/— preserving compatibility with existing installations built without the flagget_binary_path()andAcestepCPPBuilder.build()both use_binary_in_buildfor consistent fallback search.github/workflows/ci.yml— actually test the buildif: github.event_name == 'workflow_dispatch'gate frombuild-test; it now runs on every PR and push tomain_binary_in_build: checksbuild/$binthen falls back tobuild/bin/$binTests
tests/test_install.py— new, covers_binary_existsfor both search pathstests/test_nodes.py—TestBinaryInBuildandTestGetBinaryPathcovering the helper and config/PATH/not-found lookup chain💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.