Conversation
Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cover mode format detection issue
Fix cover/repaint generation failures: wrong audio dir, bad request JSON format, missing debug logs
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover mode and regular generations were silently failing due to a combination of a wrong
AUDIO_DIRpath, LM-specific fields leaking into dit-vae request JSONs, and overly strict route validation. Debug logging was absent, making these failures nearly impossible to diagnose.Root causes & fixes
server/src/config/index.ts— WrongaudioDir(primary failure cause)config.storage.audioDirresolved to<project>/public/audio(APP_ROOT= repo root), but:LocalStorageProviderwrites toserver/public/audio/audio/fromserver/public/audioresolveAudioPath('/audio/reference-tracks/…')was looking in the wrong directory —--src-audiopointed at a nonexistent path, crashingdit-vae.server/src/services/acestep.ts— Mode-specific request JSONAll modes were receiving the same JSON including LM-specific fields (
lm_temperature,lm_cfg_scale,vocal_language, etc.) that onlyace-qwen3needs.audio_cover_strengthwas also written into text2music requests.Now each mode gets only its relevant fields:
ace-qwen3audio_cover_strengthrepainting_start,repainting_endaudio_codes; throws early if missingMode detection is now driven by explicit
taskTypeflags (isCover,isRepaint,isPassthru,skipLm) rather than ad-hocsourceAudioUrlpresence checks.server/src/routes/generate.ts— Validation too strict for cover/repaintCustom-mode requests with only
sourceAudioUrl(nostyle/lyrics) were rejected. AddedrequiresSourceAudioexception so cover/audio2audio/repaint requests pass through.Debug logging added
Every generation now emits structured logs covering:
taskType,ditModel,sourceAudioURL, repaint region, user IDace-qwen3anddit-vaeCLI commands (previously truncated to 6 args), request JSON written to disk, resolved model pathsresolveAudioPath: every URL→filesystem resolution💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.