Skip to content

Surface dit-vae/ace-qwen3 binary stderr in server logs#14

Merged
lmangani merged 2 commits intomainfrom
copilot/fix-audio-paths
Mar 8, 2026
Merged

Surface dit-vae/ace-qwen3 binary stderr in server logs#14
lmangani merged 2 commits intomainfrom
copilot/fix-audio-paths

Conversation

Copy link
Contributor

Copilot AI commented Mar 8, 2026

Binary failures from dit-vae and ace-qwen3 were producing only Generation failed in the server log with no detail. The progress-handler callbacks only matched specific [DiT]/[VAE]/[Phase1]/[Decode] patterns and silently dropped everything else — including all error output from the binary.

Changes

  • makeDitVaeProgressHandler / makeLmProgressHandler: add fallback console.log for unrecognized lines so all binary output ([Audio], [Load], [Cover], [Request], errors, etc.) is visible in real-time:

    // Any unrecognized line — log it so binary errors/warnings are always visible
    console.log(`[dit-vae] ${line}`);
  • runBinary:

    • Removed the if (onLine) guard around lineBuf — the buffer is now always populated regardless of whether a callback is provided.
    • Flush remaining lineBuf content into onLine on process close — the last line (no trailing \n) was previously lost.
    • On non-zero exit, explicitly log exit code + full stderr/stdout before rejecting, so failures are unmissable even when the binary crashes before producing any progress output:
      console.error(`[${label}] exited with code ${code ?? 'null (terminated by signal)'}`);
      if (stderr) console.error(`[${label}] stderr:\n${stderr}`);

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect audio paths for reference tracks Surface dit-vae/ace-qwen3 binary stderr in server logs Mar 8, 2026
@lmangani lmangani marked this pull request as ready for review March 8, 2026 12:37
@lmangani lmangani merged commit 8fe7ad6 into main Mar 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants