Skip to content

Package lock + webpack upgrades from pr#1#4

Open
MichaelDimmitt wants to merge 3 commits intoaudriusnavickasDB:masterfrom
m-dimmitt-pr:package-lock
Open

Package lock + webpack upgrades from pr#1#4
MichaelDimmitt wants to merge 3 commits intoaudriusnavickasDB:masterfrom
m-dimmitt-pr:package-lock

Conversation

@MichaelDimmitt
Copy link

@MichaelDimmitt MichaelDimmitt commented May 23, 2021

Confirmed, this fixed #2 ! 🎉
Thanks @shuieryin

version of npm and node that I used:
node: v12.22.1
npm: 6.14.12

#1 added the following:

  1. Storybook was updated!
  2. Node-sass version for master is currently pointed to 4.11.0 which is no longer a valid release on node-sass 🤦‍♂️
    so when you try to install, it will fail if you do not already have it on your computer.

This saved me so much time trying to debug myself.

This pr adds a package-lock to help future users.
as long as node-sass does not delete a release again. 🙅‍♂️

@MichaelDimmitt MichaelDimmitt changed the title Package lock + webpack upgrades from #1 Package lock + webpack upgrades from pr#1 May 23, 2021
@darshan-g
Copy link

With the current approach my understanding is that we need to install multiple packages like @audnavlib/button, @audnavlib/button-group. Instead, how can we install the entire library(components-library) and then import the components like import Button from 'components-library/button'

@MichaelDimmitt @shuieryin @audriusnavickasDB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console Error Running Storybook

3 participants