Skip to content

fix : Guard against all uncaught exception in the serial executor block #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmathew92 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix : Guard against all uncaught exception in the serial executor block #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d41cd6
fix : catching all uncaught exception in the serial executor block
pmathew92 May 19, 2026
d0997ea
Merge branch 'main' into fix/gh-968
pmathew92 May 21, 2026
33ec14a
Added test coverage
pmathew92 May 21, 2026
9dfcfac
Added log for the catch block
pmathew92 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions auth0/src/main/java/com/auth0/android/authentication/storage/BaseCredentialsManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,19 @@ public abstract class BaseCredentialsManager internal constructor(
if (scope == null) return audience
val sortedScope = scope.split(" ").sorted().joinToString("::")
return "$audience::${sortedScope}"
}

internal inline fun <T> runCatchingOnExecutor(
callback: Callback<T, CredentialsManagerException>,
block: () -> Unit
) {
try {
block()
} catch (t: Throwable) {
Copy link
Copy Markdown
Contributor

@utkrishtsahu utkrishtsahu May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atching Throwable here means we'd also swallow OutOfMemoryError, StackOverflowError, etc. — situations where the JVM is in a bad state and the app really should crash. The old code only caught RuntimeException. Could we narrow this to Exception instead? Or re-throw Error subtypes so fatal problems don't get silently eaten:

} catch (e: Exception) {
callback.onFailure(
CredentialsManagerException(CredentialsManagerException.Code.UNKNOWN_ERROR, e)
)

Copy link
Copy Markdown
Contributor Author

@pmathew92 pmathew92 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point on catching too broadly. However, I'm intentionally keeping Throwable here — this is an SDK running on a background executor, and the entire purpose of this fix (#968) is to prevent unhandled exceptions from silently killing the host app. The rationale is that a library should never be the reason an app force-closes without explanation — the host app should own its crash policy.

Log.e("BaseCredentialsManager", "Unexpected error in executor block", t)
callback.onFailure(
CredentialsManagerException(CredentialsManagerException.Code.UNKNOWN_ERROR, t)
)
Copy link
Copy Markdown
Contributor

@utkrishtsahu utkrishtsahu May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add log
line here? Something like:

} catch (t: Throwable) {
Log.e("BaseCredentialsManager", "Unexpected error in executor block", t)
callback.onFailure(...)
}
will be helpful if a customer reports a weird failure

Copy link
Copy Markdown
Contributor Author

@pmathew92 pmathew92 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Added log to record the error

}
}
}
Loading
Loading