Skip to content

Conversation

@hazel-nut
Copy link
Contributor

small update to CODEOWNERS to give shared ownership for docs.json so writers can update the menu and redirects as part of normal content work. naturally, docs mgmt should still review any more substantial config changes.

based on the top-level structure of main/, these changes should preserve the existing ownership structure (aside from now sharing docs.json).

@hazel-nut hazel-nut requested review from a team as code owners January 28, 2026 17:04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ The order of the declarations in this file is really important to have things get resolved.

If you want to update the ownership of just the docs.json files that exist in main/ and auth4genai then the change set would be limited to adding **/docs.json to the "root config" section so it's evaluated last and assigns both teams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my intention was to share ownership of all docs.json files in the repo, of which there are only two currently. if we spawn additional mintlify sites, this rule would cover those, too.

my understanding, based on github's docs, is that the last matching pattern takes precedence.

happy to make changes -- just not understanding the issue. 🙂 can you explain or give me an example path that wouldn't have the right ownership?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after finishing coffee, i think i understand!

the default ownership of the main directory was set to docs mgmt. this caused the original issue with docs.json (and also prohibits my team from doing routine work like modifying our own README.md or adding a site-specific .vale configuration).

the existing CODEOWNERS already specifies owners for:

  • snippets/ for a4aa, but it should be across the board
  • ui/ across the board
  • package{,-lock}.json at the top level, but it should be across the board

these + the claude meta-docs are the only other relevant exceptions in main to the default ownership, hence the overall structure of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants