Skip to content

fix: clear auth state immediately on removeUser #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergioChan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clear auth state immediately on removeUser #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/AuthProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ export const AuthProvider = (props: AuthProviderProps): React.JSX.Element => {
const removeUser = React.useCallback(async () => {
if (!userManager) unsupportedEnvironment("removeUser");
await userManager.removeUser();
Copy link
Member

@pamapa pamapa Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sound like a test issue you are trying to fix.
await userManager.removeUser(); calls at the end await this._events.unload();, which will trigger the USER_UNLOADED event in this library

// keep local auth state in sync even when the underlying library
// does not emit UserUnloaded events in this runtime/test setup.
dispatch({ type: "USER_UNLOADED" });
if (onRemoveUser) await onRemoveUser();
}, [userManager, onRemoveUser]);

Expand Down
25 changes: 25 additions & 0 deletions test/AuthProvider.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,31 @@ describe("AuthProvider", () => {
expect(UserManager.prototype.removeUser).toHaveBeenCalled();
});

it("should mark user as signed out immediately after removeUser", async () => {
const mockGetUser = mocked(
UserManager.prototype,
).getUser.mockImplementation(() => {
return new Promise((resolve) => {
resolve(user);
});
});

const wrapper = createWrapper({ ...settingsStub }, false);
const { result } = renderHook(() => useAuth(), {
wrapper,
});

await waitFor(() => expect(result.current.user).toBe(user));
expect(result.current.isAuthenticated).toBe(true);

await act(() => result.current.removeUser());

await waitFor(() => expect(result.current.user).toBeUndefined());
expect(result.current.isAuthenticated).toBe(false);

mockGetUser.mockRestore();
});

it("should handle signoutSilent", async () => {
// arrange
const wrapper = createWrapper({ ...settingsStub });
Expand Down