Merged
Conversation
47940be to
cca8aaf
Compare
7a5ac6c to
4df7cb9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
=======================================
Coverage 43.03% 43.03%
=======================================
Files 38 38
Lines 6098 6098
=======================================
Hits 2624 2624
Misses 3208 3208
Partials 266 266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fdd7b17 to
fa8f103
Compare
fa8f103 to
aa73a5d
Compare
miparnisari
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509
Description
There's a couple of misbehaviors around
zed importthat we want to fix:Neither of these is desirable. This PR adds tests for those.
Changes
Added a flag
mustDefineSchemainside thedecoderthat theimportcommand sets tofalse.Testing
Included as unit tests.