Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 41.65% 42.44% +0.79%
==========================================
Files 38 38
Lines 6127 6166 +39
==========================================
+ Hits 2552 2617 +65
+ Misses 3319 3280 -39
- Partials 256 269 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes duplicate relationships during
zed backupwhen backup streams encounter retryable transport failures.There were two related issues:
ReadRelationshipswas still using the generic gRPC stream retry interceptor. On retry, that interceptor reopens the stream from the beginning, which can replay already-exported relationships and append duplicates to the backup.This PR:
ReadRelationships, matching the existing manual handling for bulk export/import{resource_type, cursor}so resume can restart at the correct definitionTesting
Ran targeted tests locally:
Added coverage for:
ReadRelationshipsnot being retried by the generic stream retry interceptorReviewers can test by:
References
Customer report describing duplicate relationships after retryable backup transport failures.