Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces automated digital signing for Windows artifacts using the SignPath OSS Foundation program. This addresses the long-standing issue of "Unknown Publisher" warnings for our Windows users.
Note: This change affects only the Windows build pipeline. Linux and macOS installers remain unaffected and continue to be processed through their existing workflows.
Changes
sign-windowsjob to the CI pipeline, running on Ubuntu for efficiency.test-signing: Used for development builds and PRs.release-signing: Reserved for official tagged releases (requires certificate approval).publishjob to wait for and use the signed Windows binaries.Impact on HyperHDR (Windows only)
.exeinstaller has not been tampered with after being built in our CI environment.Part of the transition to the SignPath Foundation program for verified Windows distribution.