fix: use identityPool provider directly in auth directive output#682
Open
fix: use identityPool provider directly in auth directive output#682
Conversation
Stop mapping identityPool to iam in SchemaProcessor auth rule generation. The transform layer handles this mapping, so the schema output should preserve the original provider name.
🦋 Changeset detectedLatest commit: f0eb3f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
osama-rizk
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
SchemaProcessorwas mappingidentityPooltoiamwhen generating auth directive output. This mapping is unnecessary at the schema level since the transform layer already handles it, and it obscures the original provider name in the generated schema.Issue number, if available:
Changes
identityPool→iamprovider mapping inSchemaProcessor.calculateAuth()identityPoolas the provider name in the schema outputCorresponding docs PR, if applicable:
Validation
identityPoolis preserved in auth directivesChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.