fix: post-merge fixes for content restructuring#8534
Merged
Conversation
…ding order The AIConversation component from @aws-amplify/ui-react-ai has known accessibility issues (missing aria-labels, missing alt text) that cause the Axe-core scan to fail. Scope the exclusion to .amplify-ai-conversation container only. Also fix heading order in pubsub/connection-states fragment.
Initialize activeSection for homepage in useState (not just useEffect), initialize MenuItem open state from URL path so SSR has correct accordion state, and add hidden attribute to collapsed lists for pre-CSS hiding.
harsh62
changed the title
This reverts commit 5f2c052.
ekjotmultani
previously approved these changes
Mar 26, 2026
pranavosu
previously approved these changes
Mar 26, 2026
thisisabhash
previously approved these changes
Mar 26, 2026
…ydration and a11y errors
harsh62
dismissed stale reviews from thisisabhash, pranavosu, and ekjotmultani
via
3d47437
thisisabhash
approved these changes
Mar 27, 2026
ekjotmultani
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes after merging the section navigation (#8528) and content restructuring (#8531) PRs.
<AIConversation>component demos from Axe-core scan (upstream library a11y issues in@aws-amplify/ui-react-ai), addeslint root:truehiddenattribute to collapsed lists, set homepage section inuseStateinitializer to prevent FOUCTest plan
npx jest— all tests pass/react/) — no sidebar menu flash on load/react/build-a-backend/auth/set-up-auth/) — sidebar loads with correct accordion state