Skip to content

Add latest intEnum and signature versions #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onno-vos-dev merged 1 commit into from
Jan 28, 2026
Merged

Add latest intEnum and signature versions #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/aws_codegen/types.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ defmodule AWS.CodeGen.Types do
type =
"#{AWS.CodeGen.Name.to_snake_case(String.replace(shape_name, ~r/com\.amazonaws\.[^#]+#/, ""))}"
|> AWS.CodeGen.Util.maybe_add_parens()

if reserved_type(type) do
"#{String.downcase(String.replace(context.module_name, ["aws_", "AWS."], ""))}_#{type}"
else
Expand Down Expand Up @@ -158,6 +157,7 @@ defmodule AWS.CodeGen.Types do
defp shape_to_type(_, %Shape{type: "integer"}, _module_name), do: "integer()"
defp shape_to_type(_, %Shape{type: "boolean"}, _module_name), do: "boolean()"
defp shape_to_type(_, %Shape{type: "enum"}, _module_name), do: "list(any())"
defp shape_to_type(_, %Shape{type: "intEnum"}, _module_name), do: "list(integer())"
defp shape_to_type(_, %Shape{type: "union"}, _module_name), do: "list()"
defp shape_to_type(_, %Shape{type: "document"}, _module_name), do: "any()"

Expand Down Expand Up @@ -198,7 +198,7 @@ defmodule AWS.CodeGen.Types do
end

defp reserved_type(type) do
type == "node" || type == "term" || type == "function" || type == "reference" || type == "identifier"
type == "node" || type == "term" || type == "function" || type == "reference" || type == "identifier" || type == "none" || type == "none()"
Copy link
Member Author

@onno-vos-dev onno-vos-dev Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little bit funky to support none and none() here but it's a bit finicky to get these types to work properly and this at least covers the None type that AWS introduced recently so I'll let it be for the time being.

end

def function_argument_type(:elixir, action) do
Expand Down
1 change: 1 addition & 0 deletions lib/aws_codegen/util.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ defmodule AWS.CodeGen.Util do

case signature do
["aws.auth#sig" <> version] -> version
["aws.auth#sigv4", "aws.auth#sigv4a"] -> "aws.auth#sigv4"
[] -> nil
end
end
Expand Down
Loading