fix reload server method

[pete911]

Description of the issue

Describe the problem or feature in addition to a link to the issues.

Description of changes

server.Close only closes connections and does not wait for server shutdown. We can see this behaviour in the logs:

failed to serve and listen","error":"listen tcp :4311: bind: address already in use
failed to serve and listen","error":"http: Server closed"
failed to serve and listen","error":"http: Server closed"
failed to serve and listen","error":"http: Server closed"

http: Server closed error is coming from ListenAndServeTLS (s.shuttingDown() check, this means that the server is not shut down. After multiple tries, we get error from net.Listen. By using Shutdown(...) instead of Close(), the code is going to wait for server shutdown, not just for connections to be closed.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Existing tests were re-run and are working. This change does not introduce any new behaviour.

Requirements

Before commiting your code, please do the following steps.

1. Run make fmt and make fmt-sh
2. Run make lint

---

Integration Tests

To run integration tests against this PR, add the ready for testing label.

[github-actions]

This PR was marked stale due to lack of activity.

[pete911]

why was this marked as stale? Plus there are not reviewers ...

[github-actions]

This PR was marked stale due to lack of activity.

[pete911]

any update on this? It keeps getting labeled as stale

[github-actions]

This PR was marked stale due to lack of activity.

[pete911]

why is this stale if it is marked as ready for testing

[github-actions]

This PR was marked stale due to lack of activity.

[pete911]

@zhihonl is this going to be merged? it keeps getting marked as stale and I cannot see any activity/interest in this PR

[github-actions]

This PR was marked stale due to lack of activity.

[github-actions]

This PR was marked stale due to lack of activity.

[github-actions]

This PR was marked stale due to lack of activity.

[github-actions]

This PR was marked stale due to lack of activity.

[pete911]

@mitali-salvi any update on this? There seems to be unrelated errors in your pipelines:

Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

Anything you need me to update?

[jreisinger]

@pete911 respect for your perseverance! :-)