Open
Conversation
aws_advanced_python_wrapper/aurora_initial_connection_strategy_plugin.py
Outdated
Show resolved
Hide resolved
sophia-bq
force-pushed
the
feat/gdb-infrastructure
branch
from
7fef560 to
7d246ff
Compare
faviansamatha
approved these changes
Mar 13, 2026
karenc-bq
reviewed
Mar 17, 2026
|
|
||
| rds_type = self._rds_utils.identify_rds_type(host) | ||
| if rds_type == RdsUrlType.RDS_GLOBAL_WRITER_CLUSTER: | ||
| self._region_utils: RegionUtils = GdbRegionUtils() |
Contributor
There was a problem hiding this comment.
Need to pass a custom credentials provider here, otherwise gdb region utils would try to use local credentials to retrieve region information, instead of using saml to authenticate.
karenc-bq
reviewed
Mar 17, 2026
| MonitorService.ErrorPopulatingAliases=[MonitorService] An error occurred while populating aliases: '{}'. | ||
|
|
||
| GlobalAuroraTopologyUtils.UnsupportedOperationError=[GlobalAuroraTopologyUtils] Aurora global databases does not support this operation {}. | ||
| GlobalAuroraTopologyUtils.globalClusterInstanceHostPatternsRequired=[GlobalAuroraTopologyUtils] Parameter 'globalClusterInstanceHostPatterns' is required for Aurora Global Database. |
Contributor
There was a problem hiding this comment.
Suggested change
| GlobalAuroraTopologyUtils.globalClusterInstanceHostPatternsRequired=[GlobalAuroraTopologyUtils] Parameter 'globalClusterInstanceHostPatterns' is required for Aurora Global Database. | |
| GlobalAuroraTopologyUtils.globalClusterInstanceHostPatternsRequired=[GlobalAuroraTopologyUtils] Parameter 'global_cluster_instance_host_patterns' is required for Aurora Global Database. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.