refactor: use projen primitives for custom workflow definitions#1322
Merged
aws-cdk-automation merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Replace hardcoded setup-node, install, and command steps in custom workflow definitions with projen's renderWorkflowSetup() and runTaskCommand() primitives. Create a proper publish-to-adc projen task.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=======================================
Coverage 88.19% 88.20%
=======================================
Files 73 73
Lines 10386 10386
Branches 1410 1409 -1
=======================================
+ Hits 9160 9161 +1
+ Misses 1199 1198 -1
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom GitHub workflow definitions in
projenrc/hardcode Node.js setup steps and shell commands likeyarn workspaces run bumpornpx tsx projenrc/publish-to-adc.task.ts. This means that whenever the project's package manager or tooling changes (e.g. migrating from Yarn Classic to Berry), every custom workflow needs to be manually updated to match. Meanwhile, projen-managed workflows already handle this automatically throughrenderWorkflowSetup()andrunTaskCommand().This refactoring replaces the manual step definitions with projen primitives across all three custom workflow files. In
adc-publishing.ts, the hardcodedsetup-nodeandyarn installsteps are replaced withrenderWorkflowSetup(), and the directnpx tsxinvocation is wrapped in a properpublish-to-adcprojen task that is then called viarunTaskCommand(). Incdk-cli-integ-tests.ts, the same setup replacement is applied, and the hardcodedyarn workspaces run bumpandnpx projen buildcommands are replaced with theirrunTaskCommand()equivalents. Incodecov.ts, the manual setup steps are similarly replaced withrenderWorkflowSetup().The regenerated workflow YAML files reflect these changes:
actions/setup-nodeis updated from v4 to v6, thepackage-manager-cachesetting is now explicitly configured, and all task invocations go throughnpx projeninstead of direct tool calls. These are all consequences of using the projen primitives rather than manual changes.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license