[v2] Warn on credentials file permissions#10334
Closed
kdaily wants to merge 1 commit into
Closed
Conversation
Users running the following commands now see a warning if the credentials file has permissions beyond the default of 0o600. - `aws configure set` (if setting access key,secret key, or token) - `aws configure` (if setting access key,secret key, or token) - `aws configure import` - `aws configure mfa-login` Developers can now specify a credential check in the `ConfigFileWriter.update_config` method. This is used in all instances except for `configure import` so that a warning message is only printed once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#10019
Description of changes:
Users running the following commands now see a warning if the credentials file has permissions beyond the default of
0o600.aws configure set(if setting access key,secret key, or token)aws configure(if setting access key,secret key, or token)aws configure importaws configure mfa-loginDevelopers can now specify a credential check in the
ConfigFileWriter.update_configmethod. This is used in all instances except forconfigure importso that a warning message is only printed once.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.