Skip to content

[Test] Add caching to flexible instance type retrieval to minimize the number of EC2 requests. #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gmarciani wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Test] Add caching to flexible instance type retrieval to minimize the number of EC2 requests. #7402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration-tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@
generate_stack_name,
get_architecture_supported_by_instance_type,
get_arn_partition,
get_flexible_instance_types,
get_instance_info,
get_metadata,
get_network_interfaces_count,
get_similar_instance_types,
get_vpc_snakecase_value,
random_alphanumeric,
to_pascal_case,
Expand Down Expand Up @@ -698,7 +698,7 @@ def inject_placement_group_settings(vpc_stack, instance, region, kwargs):


def inject_flexible_instance_types_settings(instance, region, kwargs):
kwargs["flexible_instance_types"] = list({instance, *get_similar_instance_types(instance, region, 5)})
kwargs["flexible_instance_types"] = get_flexible_instance_types(instance, region)


def inject_additional_image_configs_settings(image_config, request):
Expand Down
6 changes: 6 additions & 0 deletions tests/integration-tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,12 @@ def get_similar_instance_types(instance_type: str, region: str = None, max_items
return similar_instances


@cache
def get_flexible_instance_types(instance, region):
"""Return ``instance`` plus up to 5 similar instance types available in ``region``"""
return list({instance, *get_similar_instance_types(instance, region, 5)})


@cache
def get_flexible_gpu_instance_types(instance, region):
"""Return a list of NVIDIA GPU instance types compatible with ``instance``'s architecture."""
Expand Down
Loading