Skip to content

Conversation

@kai-ion
Copy link
Contributor

@kai-ion kai-ion commented Jan 13, 2026

Issue #, if available:

Description of changes:
Smithy-based code generator for paginators

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

public CppWriter writeNamespaceClose(String namespace) {
write("} // namespace $L", namespace);
return this;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being a bit nitpicky but Instead of manually opening and closing namespace blocks, why don't we do something like this:

public CppWriter writeNamespaceOpen(String namespace) {
        writer.openBlock("namespace $L\n{", namespace);
        return this;
 }

and the same for writeNamespaceClose, but with writer.closeBlock. Its functionally the exact same (block functions indent/dedent which doesn't matter since we clang format anyway) , but we should try to use these functions when opening/closing blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants