Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The Velocity template for serializing sparse (nullable) list and map
elements had two issues:
Called AsNull() on JsonValue array elements, but AsNull() only exists on the CRT's JsonObject, not on the SDK's JsonValue wrapper.
Used *optional.Method() to access the inner value of Optional-wrapped elements. Due to C++ operator precedence, .Method() binds to the Optional rather than the dereferenced value. This is harmless for simple types (strings, ints) where computeJsonizeString returns empty, but breaks for structures (.Jsonize()), timestamps (.SecondsWithMSPrecision()), and documents (.View()). Fixed by using optional->Method() via computeJsonizeString(shape, true) for types that require a method call.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.