Include channel diagnostics in Read/Write timeout error messages in n…#6839
Open
Include channel diagnostics in Read/Write timeout error messages in n…#6839
Conversation
Fred1155
approved these changes
Apr 3, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and Context
Read and write timeout errors from the Netty client previously only included a plain message like "Read timed out" or "Write timed out" without any channel context. In contrast,
ClosedChannelExceptionand connection reset errors already included channel diagnostics. This made debugging timeout issues harder since there was no visibility into channel state at the time of failure.Modifications
closedChannelMessageintoerrorMessageWithChannelDiagnosticsthat accepts a custom message parameterdecorateExceptionto include channel diagnostics forReadTimeoutExceptionandWriteTimeoutExceptionclosedChannelMessageas a delegate for existing callerselse ifchain to separateifblocks for readabilitydecorateExceptiontests using parameterized testsTesting
errorMessageWithChannelDiagnosticswith null channel and with diagnostics presentTypes of changes
Checklist
mvn clean install -pl :netty-nio-clientsucceedsLicense