Skip to content

fix: use correct 'score' field for memory relevance filtering #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesseturner21 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

fix: use correct 'score' field for memory relevance filtering #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
109b320
fix: use correct 'score' field for memory relevance filtering (#365)
jesseturner21 May 15, 2026
88cf59b
fix: use threshold as default when score field is absent
jesseturner21 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bedrock_agentcore/memory/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ def _retrieve_memories_for_llm(
memory_records = [
record
for record in memory_records
if record.get("relevanceScore", config.relevance_score) >= config.relevance_score
if record.get("score", config.relevance_score) >= config.relevance_score
]
retrieved_memories.extend(memory_records)

Expand Down
4 changes: 2 additions & 2 deletions tests/bedrock_agentcore/memory/models/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ def test_memory_record_initialization(self):
"memoryRecordId": "record-123",
"content": {"text": "This is a memory record"},
"namespace": "user/preferences/",
"relevanceScore": 0.95,
"score": 0.95,
"createdAt": "2023-01-01T00:00:00Z",
}
memory_record = MemoryRecord(data)

assert memory_record._data == data
assert memory_record.memoryRecordId == "record-123"
assert memory_record["content"]["text"] == "This is a memory record"
assert memory_record.get("relevanceScore") == 0.95
assert memory_record.get("score") == 0.95

def test_memory_record_dict_access(self):
"""Test MemoryRecord dictionary-like access."""
Expand Down
6 changes: 3 additions & 3 deletions tests/bedrock_agentcore/memory/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2881,9 +2881,9 @@ def test_process_turn_with_llm_with_relevance_score_filtering(self):

# Mock search_long_term_memories to return records with different relevance scores
mock_memories = [
{"content": {"text": "High relevance"}, "memoryRecordId": "rec-1", "relevanceScore": 0.8},
{"content": {"text": "Low relevance"}, "memoryRecordId": "rec-2", "relevanceScore": 0.2},
{"content": {"text": "Medium relevance"}, "memoryRecordId": "rec-3", "relevanceScore": 0.5},
{"content": {"text": "High relevance"}, "memoryRecordId": "rec-1", "score": 0.8},
{"content": {"text": "Low relevance"}, "memoryRecordId": "rec-2", "score": 0.2},
{"content": {"text": "Medium relevance"}, "memoryRecordId": "rec-3", "score": 0.5},
]
with patch.object(manager, "search_long_term_memories", return_value=mock_memories):
# Mock add_turns
Expand Down
Loading