Remove unused retry logic in proxy server#1197
Draft
Conversation
6ff81f4 to
c6444f1
Compare
c6444f1 to
dc749a0
Compare
Collaborator
Author
|
Marking this as draft as I have some other cleanup work to do first and this is not necessary for SPARQL query editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the retry logic inside of the proxy server APIs.
The retry logic had a
refetchMaxRetriesdefault value of 1 andi < refetchMaxRetries. This meant only 0 is less than 1, resulting in a single execution of theforloop.The client already has built in retries with Tanstack Query that we are dependent on. In addition, certain queries may require disabling the retry logic, which is only possible from the client. So retry logic in the server is not useful.
Validation
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.