fix(infra): use cross-platform compatible checks script#1528
Closed
fix(infra): use cross-platform compatible checks script#1528
Conversation
Replace the pnpm regex pattern `'/^check:.*/'` with explicit command chaining using `&&`. The regex pattern with single quotes does not work properly on Windows cmd.exe, causing `pnpm checks` to fail. The explicit commands are cross-platform compatible and run the same check scripts: check:lint, check:format, and check:types. Fixes aws#1512 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Closing as duplicate of #1525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the pnpm regex pattern in the
checksscript with explicit command chaining, fixing the script on Windows.Before:
After:
Root Cause
The single quotes around the regex pattern
'/^check:.*/'are not properly interpreted by Windows cmd.exe, causingpnpm checksto fail on Windows systems.Changes
package.jsonto use explicit command chaining with&&instead of the pnpm regex patterncheck:lint,check:format, andcheck:typesTest Plan
&&operator is cross-platform compatible (works on Windows cmd.exe, PowerShell, and Unix shells)Fixes #1512