Consolidate edge discovery into SchemaDiscoveryBoundary#1530
Open
Consolidate edge discovery into SchemaDiscoveryBoundary#1530
Conversation
- Remove EdgeDiscoveryBoundary in favor of requireEdgeConnections prop on SchemaDiscoveryBoundary - Simplify schema failure tracking: rename edgeConnectionDiscoveryFailed to lastEdgeConnectionSyncFail, remove triedToSync - Add staleTime: Infinity to schema and edge connection queries for explicit cache control - Derive edge connection initialData from Jotai store with edge type filtering - Simplify error handling in schemaSyncQuery and edgeConnectionsQuery
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
===========================================
+ Coverage 47.81% 64.69% +16.88%
===========================================
Files 382 355 -27
Lines 8525 7919 -606
Branches 3159 2890 -269
===========================================
+ Hits 4076 5123 +1047
+ Misses 3070 2012 -1058
+ Partials 1379 784 -595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the separate
EdgeDiscoveryBoundarycomponent intoSchemaDiscoveryBoundaryvia arequireEdgeConnectionsprop, simplifying the schema discovery flow.EdgeDiscoveryBoundaryin favor ofrequireEdgeConnectionsprop onSchemaDiscoveryBoundaryedgeConnectionDiscoveryFailedtolastEdgeConnectionSyncFail, removetriedToSyncstaleTime: Infinityto schema and edge connection queries for explicit cache controlinitialDatafrom Jotai store with edge type filteringschemaSyncQueryandedgeConnectionsQueryValidation
requireEdgeConnectionsCheck List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.