Skip to content

Comments

Consolidate edge discovery into SchemaDiscoveryBoundary#1530

Open
kmcginnes wants to merge 1 commit intoaws:mainfrom
kmcginnes:feature/schema/initial-data
Open

Consolidate edge discovery into SchemaDiscoveryBoundary#1530
kmcginnes wants to merge 1 commit intoaws:mainfrom
kmcginnes:feature/schema/initial-data

Conversation

@kmcginnes
Copy link
Collaborator

Description

Consolidates the separate EdgeDiscoveryBoundary component into SchemaDiscoveryBoundary via a requireEdgeConnections prop, simplifying the schema discovery flow.

  • Remove EdgeDiscoveryBoundary in favor of requireEdgeConnections prop on SchemaDiscoveryBoundary
  • Simplify schema failure tracking: rename edgeConnectionDiscoveryFailed to lastEdgeConnectionSyncFail, remove triedToSync
  • Add staleTime: Infinity to schema and edge connection queries for explicit cache control
  • Derive edge connection initialData from Jotai store with edge type filtering
  • Simplify error handling in schemaSyncQuery and edgeConnectionsQuery

Validation

  • Verified schema sync and edge connection discovery work end-to-end
  • Confirmed Schema Explorer gates on edge connections via requireEdgeConnections
  • Checked that persisted failure flags prevent automatic retries across sessions
  • All existing tests updated and passing

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

- Remove EdgeDiscoveryBoundary in favor of requireEdgeConnections prop on SchemaDiscoveryBoundary
- Simplify schema failure tracking: rename edgeConnectionDiscoveryFailed to lastEdgeConnectionSyncFail, remove triedToSync
- Add staleTime: Infinity to schema and edge connection queries for explicit cache control
- Derive edge connection initialData from Jotai store with edge type filtering
- Simplify error handling in schemaSyncQuery and edgeConnectionsQuery
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.69%. Comparing base (c5affc5) to head (4074dcc).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1530       +/-   ##
===========================================
+ Coverage   47.81%   64.69%   +16.88%     
===========================================
  Files         382      355       -27     
  Lines        8525     7919      -606     
  Branches     3159     2890      -269     
===========================================
+ Hits         4076     5123     +1047     
+ Misses       3070     2012     -1058     
+ Partials     1379      784      -595     
Flag Coverage Δ
unittests 64.69% <100.00%> (+16.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kmcginnes kmcginnes marked this pull request as ready for review February 20, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant