Add styling import / export / reset UI#1784
Closed
jkemmererupgrade wants to merge 2 commits into
Closed
Conversation
Stores icon selections as symbolic lucide:<name> references rather than data URIs, so config files remain human-readable and the picker can highlight the current selection without reverse-engineering the blob. Resolution happens at render time via two paths: - React components (VertexIcon): useResolvedIconUrl hook backed by React Query (staleTime: Infinity) converts lucide:<name> to a base64 SVG data URI on first use and caches the result. - Cytoscape pipeline (renderNode): getLucideSvgString resolves directly from the lucide-react dynamic-import map, skipping any fetch round-trip. Custom-uploaded icons (data: URIs and plain URLs) are unchanged -- they pass through both resolvers untouched. The new IconPicker component (searchable popover, 8-column grid, 50-icon default window) is wired into NodeStyleDialog alongside the existing file upload button so users can choose a Lucide icon or keep uploading their own. Also fixes a pre-existing lint-staged misconfiguration where the root oxlint --fix task matched vitest.config.ts, which oxlint then ignored (matching its own ignorePatterns), causing exit code 1. The root lint-staged config now mirrors the oxlint ignorePatterns by routing *.config.* files to oxfmt only and restricting oxlint to packages/. Pre-flight: pnpm checks, pnpm test (1738/1738), pnpm coverage all pass. This is Slice 1 of the 3-slice split of aws#1589 per @kmcginnes review.
Add three buttons to the General Settings page: - Export: downloads current vertex and edge styling as graph-explorer-styling.json - Import: loads a JSON file, applies it as the live styling baseline, and stores it in defaultStylingAtom so per-type Reset on the node style dialog restores to imported values rather than application defaults - Reset All: reverts every vertex and edge to the imported baseline (or application defaults if no file has been imported this session) Introduce defaultStyling.ts with a Zod schema (DefaultStylingSchema), parseDefaultStyling, resolveDefaultStyling (converts lucide:<name> shorthand to iconUrl references established by the Lucide icon picker in PR aws#1777), and userStylingToExportFormat. The file format round-trips cleanly via lucide:<name> refs. Add mergeDefaultsIntoUserStyling to userPreferences.ts so imported baselines fill gaps for unstyled types without overwriting user customisations. Update toJsonFileData with an optional indent param (defaults unchanged) so the exported file is human-readable. Add unit tests for the schema, parse/resolve pipeline, hooks, and reset behaviour. Update docs/features/settings.md and docs/features/graph-view.md accordingly. Slice 2 of the 3-slice split of aws#1589. Stacks on aws#1777 (Lucide icon picker).
Author
|
Closing — reopening as a stacked PR against #1777's branch in the fork. See replacement PR link in a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slice 2 of 3 in the split of #1589, per @kmcginnes's review. This slice adds manual styling control to the General Settings page.
Three new buttons in General Settings:
graph-explorer-styling.json(pretty-printed, 2-space indent). Useful for sharing a styling baseline with teammates or keeping a backup.defaultStylingAtom. After import, per-type Reset in the Node Styling dialog restores to the imported values rather than application hardcoded defaults.Supporting changes:
defaultStyling.ts— Zod schema (DefaultStylingSchema),parseDefaultStyling,resolveDefaultStyling(convertslucide:<name>shorthand established in slice 1 toiconUrlreferences), anduserStylingToExportFormat. The file format round-trips cleanly through export → import.defaultStylingAtom.ts— Jotai atom storing the imported baseline for the session.mergeDefaultsIntoUserStylinginuserPreferences.ts— fills in unstyled types from the imported baseline without overwriting user customisations.resetVertexStyle/resetEdgeStyleupdated to restore from the imported baseline (falls back to hardcoded defaults if no import exists).toJsonFileDatagets an optionalindentparameter (defaults unchanged; existing callers unaffected).docs/features/settings.mdanddocs/features/graph-view.mdupdated with new feature bullets.Deliberately out of scope (slice 3):
/defaultStylingroute inapp.ts(blocked on Unified server configuration file #1660)AppStatusLoader.tsxexample/defaultStyling.jsonValidation
All pre-flight gates pass:
pnpm run check:types— clean (0 errors)pnpm run check:lint— 0 errors, 0 warnings (oxlint)pnpm run check:format— clean (oxfmt)pnpm test— 1787 / 1787 passpnpm coverage— all 4 thresholds met (statements 65.19%, branches 45.47%, functions 58.81%, lines 72.59%; branches floor auto-bumped 45 to 45 from genuine improvement in slice-2 test additions)Manual validation against a Neptune connection (k8s port-forwarded backend):
Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.